Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validators): allow any values for isIn/notIn #1124

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

lukashroch
Copy link
Collaborator

This is a follow up of sequelize/sequelize#12962, which has now been fixed in sequelize 6.8.0. Since types are now fixed in sequelize, decorator types can now be correctly aligned with the implementation. Fixes #866.

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #1124 (f04f3e7) into master (ea006fc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         117      117           
  Lines        1125     1125           
  Branches      128      128           
=======================================
  Hits         1070     1070           
  Misses         23       23           
  Partials       32       32           
Impacted Files Coverage Δ
src/validation/is-in.ts 100.00% <100.00%> (ø)
src/validation/not-in.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea006fc...f04f3e7. Read the comment docs.

@theoludwig theoludwig merged commit d25b392 into sequelize:master Oct 25, 2021
@lukashroch lukashroch deleted the is-in-fix branch October 25, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsIn validation is not allowed for numbers
2 participants