Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DK always expanded down on IE #301

Closed
tasiek opened this issue Jun 25, 2015 · 7 comments
Closed

DK always expanded down on IE #301

tasiek opened this issue Jun 25, 2015 · 7 comments
Milestone
v2.1.8

Comments

@tasiek
Copy link

tasiek commented Jun 25, 2015

Dropdown is always expanded down on IE.

I've made a debug, the issue is quite simple: window.scrollY is used, but not supported on IE. To make it work, we need to change it to: (window.scrollY || window.pageYOffset)
@Robdel12
Copy link
Owner

Thanks for the issue! Do you happen to know what version of IE this is happening in?

@Robdel12 Robdel12 added the Bug label Jun 25, 2015
@tasiek
Copy link
Author

tasiek commented Jun 25, 2015

I'm pretty sure window.scrollY is not supported by any IE (i was testing on IE10), and window.pageYOffset is a better, cross-browser alternative. Additionaly, for IE < 9 we need some additional effort.. Here are some details.

@spoonben
Copy link

I actually haven't run into this issue, IE9+

@Robdel12
Copy link
Owner

I actually couldn't replicate this. Can you JSBin or gist up your code?

@kipusoep
Copy link

sigh
Running into this issue as well while we have DK fully implemented in one of our websites. FML

kipusoep added a commit to kipusoep/DropKick that referenced this issue Apr 20, 2016
@kipusoep
Fixed Robdel12#301
1b2eb98
@kipusoep kipusoep mentioned this issue Apr 20, 2016
Closed
@Robdel12 Robdel12 reopened this Apr 20, 2016
@Robdel12 Robdel12 added this to the v2.1.8 milestone Apr 20, 2016
@Robdel12 Robdel12 removed the Bug label Apr 20, 2016
@Robdel12
Copy link
Owner

Removing the bug label until I can reproduce.

@Robdel12
Copy link
Owner

Can I get a bump on this? Also is anyone using requirejs?

Robdel12 added a commit that referenced this issue Apr 24, 2016
@Robdel12
Fix IE bug with opening DK select. Fixes #301
ce2931e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.8
Development

No branches or pull requests
4 participants
@kipusoep @Robdel12 @spoonben @tasiek