Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatibility with PHP 7.2 #219

Closed
asgrim opened this issue Nov 8, 2016 · 8 comments
Closed

Check compatibility with PHP 7.2 #219

asgrim opened this issue Nov 8, 2016 · 8 comments
Assignees
Milestone

Comments

@asgrim
Copy link
Member

asgrim commented Nov 8, 2016

Currently .travis.yml doesn't check PHP nightly (or even 7.1 for that matter) so we should add that in.

Related, and may be of relevance to this: https://twitter.com/WyriHaximus/status/796016769525809152

Thanks for hat tip to @WyriHaximus

@WyriHaximus
Copy link
Contributor

No problem @asgrim, I'll try to uncover more details and keep you posted. Also you might want to put nightly on allowed to fail for now as it's codebase is volatile.

@Ocramius
Copy link
Member

Ocramius commented Nov 8, 2016

Note: 7.2 cannot really be tested in depth without Zend\Code supporting it (yet)

@WyriHaximus
Copy link
Contributor

Think I just ruled out an issue with ReflectionClass::getDocComment, will continue digging to see why the code behaves in unexpected ways: https://twitter.com/WyriHaximus/status/796094099858321409

@WyriHaximus
Copy link
Contributor

The issue has been uncovered, calling get_class with null as argument is deprecated in 7.2, https://twitter.com/kelunik/status/796098864419835904, and thus raises an error. As demonstrated at https://travis-ci.org/WyriHaximus/php-7.2-tests/jobs/174334333#L177 with https://github.com/WyriHaximus/php-7.2-tests/blob/master/test.php Origin RFC: https://wiki.php.net/rfc/get_class_disallow_null_parameter

Sorry for jumping the gun a wee bit 😊

@asgrim
Copy link
Member Author

asgrim commented Nov 9, 2016

Ah yes, that makes sense. Thanks for reporting back @WyriHaximus :)

@WyriHaximus
Copy link
Contributor

No problem @asgrim, it is the least I can do :)

@kukulich
Copy link
Collaborator

kukulich commented Sep 6, 2017

This could be closed probably.

@Ocramius
Copy link
Member

Ocramius commented Sep 6, 2017

Can indeed be closed: handled in #316

@Ocramius Ocramius closed this as completed Sep 6, 2017
@Ocramius Ocramius self-assigned this Sep 6, 2017
@Ocramius Ocramius added this to the 2.0.0 milestone Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants