Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Formatter] Indentation error on nested div/django #423

Closed
3 tasks done
christopherpickering opened this issue Oct 11, 2022 · 2 comments · Fixed by #424
Closed
3 tasks done

[BUG] [Formatter] Indentation error on nested div/django #423

christopherpickering opened this issue Oct 11, 2022 · 2 comments · Fixed by #424
Labels
🦠 bug Something isn't working released 🧽 formatter

Comments

@christopherpickering
Copy link
Contributor

  • I'm on the latest version of djLint
  • I've searched the issues
  • I've read the docs
    code snippet with incorrect indentation:
<div>
    {% if profile_type != "user" %}
        <div class="column {% if 1 %}is-one-third-desktop is-half-tablet {% else %} is-half {% endif %}">
            <div class="bar-data-wrapper profile"
                 data-url="{% url "sketch:users" type=profile_type pk=profile_id %}"
                 data-parameters="{#[email protected]#}"
                 data-target="profile-{{ profile_type }}-{{ profile_id }}">
        </div>
    </div>
{% endif %}
</div>
@christopherpickering
Copy link
Contributor Author

Seems to be coming from the inline comment inside a param.

christopherpickering added a commit that referenced this issue Oct 12, 2022
@christopherpickering
fix(formatter): fixed formatting on nested inline comments
a86df43 
closes #423
Merged
christopherpickering pushed a commit that referenced this issue Oct 12, 2022
@semantic-release-bot
chore(release): 1.19.0 [skip ci]
d69fd8f 
# [1.19.0](v1.18.0...v1.19.0) (2022-10-12)

### Bug Fixes

* **formatter:** fixed formatting on nested inline comments ([a86df43](a86df43)), closes [#423](#423)

### Features

* **configuration:** allow local configuration to override global config ([b4cbcb4](b4cbcb4)), closes [#422](#422)
@christopherpickering
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🦠 bug Something isn't working released 🧽 formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(formatter): fixed formatting on nested inline comments djlint/djLint
1 participant
@christopherpickering