Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on compile...Easy fix #10

Open
MikeWilkie opened this issue Nov 22, 2020 · 0 comments
Open

Error on compile...Easy fix #10

MikeWilkie opened this issue Nov 22, 2020 · 0 comments

Comments

@MikeWilkie
Copy link

Not sure what's going on, but every time there's a new update to any riskified magento module there are several blatant issues that prevent magento from even compiling static content. How does that even make it into a commit?

Anyway, this was discovered less than 30 seconds after installing...I'm sure there will be more.

In etc/di.xml:

    <type name="Magento\Framework\Console\CommandList">
        <arguments>
            <argument name="commands" xsi:type="array">
                <item name="riskfied_send_historical_orders" xsi:type="object">Riskified\Decider\Model\Command\UploadHistoricalOrders</item>
            </argument>
        </arguments>
    </type>

But it should be....

    <type name="Magento\Framework\Console\CommandListInterface">
        <arguments>
            <argument name="commands" xsi:type="array">
                <item name="riskfied_send_historical_orders" xsi:type="object">Riskified\Decider\Model\Command\UploadHistoricalOrders</item>
            </argument>
        </arguments>
    </type>

Currently results in an error:

In ClassReader.php line 26:
Class Riskified\Decider\Command\UploadHistoricalOrders does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant