Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When finding nodes, we should bail on nodes without a proper hostname #703

Open
KAllan357 opened this issue Apr 29, 2014 · 2 comments
Open

Comments

@KAllan357
Copy link
Contributor

Somehow, a Chef server can end up with improper Node objects.

For example, our server had:

Node Name:   node123
Environment: kyle_env
FQDN:
IP:
Run List:    recipe[cookbook::recipe]
Roles:
Recipes:
Platform:
Tags:

If the MB plugin is configured with the right groups, MB will find this node and attempt to operate on it. We should raise some sort of helpful error message "Hey, this node has no connectable information" and just ignore it. Or we could fail the whole run.

@KAllan357
Copy link
Contributor Author

I guess technically, this code should be working, but maybe it is too strict.

https://github.com/RiotGames/motherbrain/blob/master/lib/mb/node_querier.rb#L127-L129

@capoferro
Copy link
Contributor

As far as I understand, #present? is the same as !blank?, which means an empty string or nil should not pass the #present? check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants