Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication errors cause #node_name to return nil #667

Open
capoferro opened this issue Feb 28, 2014 · 0 comments
Open

Authentication errors cause #node_name to return nil #667

capoferro opened this issue Feb 28, 2014 · 0 comments

Comments

@capoferro
Copy link
Contributor

https://github.com/RiotGames/motherbrain/blob/master/lib/mb/node_querier.rb#L93

This should catch authentication errors and notify the user that the node is not reachable due to failed authentication rather than just returning nil, making the caller think the node does not have a node_name.

In broader strokes, this error handling should be much more fine grained rather than just being a catch all.

This behavior was observed when communicating with windows nodes over winrm. Unsure if this occurs over ssh as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant