Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQUEST] Allow filtering TFT matches by queue ID and/or type #935

Open
tomwmth opened this issue May 22, 2024 · 0 comments
Open

Comments

@tomwmth
Copy link

tomwmth commented May 22, 2024

LoL's match-v5 allows for queue and type query parameters to be passed to the matches/by-puuid/{puuid}/ids method. This causes it to return a list of match IDs filtered by either of them. The exact same method in tft-match-v1 lacks these two parameters,

I have a use-case where I only care about the latest ranked game for a given player. This is trivial to do with the LoL API as I can set the queue ID to that of Ranked Solo/Duo and the number of returned matches to 1. I believe this is not a necessarily unusual use case for smaller projects using the API, although I will admit larger projects like match history sites are unlikely to encounter this.

The best way I can see to achieve this with tft-match-v1 is to request a bunch of match IDs, then iterate through them and make a request to matches/{matchId} to check the queue ID. This itself would potentially need to be iterative until you reach some arbitrary limit of matches to look through before stopping. The DX of this is obviously worse and significantly increases the amount of API calls that need to be made for any adjacent use-cases. Additionally, two-way traffic needlessly increases as a matches/{matchId} call contains a large amount of data which has a good chance of being ignored.

Implementing these query parameters seems like a logical upgrade to tft-match-v1 to bring it more inline with match-v5.

@tomwmth tomwmth changed the title Allow filtering TFT matches by queue ID and/or type [FEATURE-REQUEST] Allow filtering TFT matches by queue ID and/or type May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants