Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notificationItem : href does not work #322

Closed
mick-weber opened this issue Nov 24, 2022 · 1 comment
Closed

notificationItem : href does not work #322

mick-weber opened this issue Nov 24, 2022 · 1 comment
Labels
fixed-in-dev Fixed in development version

Comments

@mick-weber
Copy link

mick-weber commented Nov 24, 2022

Hello, I noticed that href argument from notificationItem() does not work. When clicked, it simply opens a new browser tab with a # sign appended. This looks very similar to this issue. See reprex below.

if (interactive()) {
library(shiny)
library(bs4Dash)

shinyApp(
  ui = dashboardPage(
    header = dashboardHeader(
      leftUi = tagList(

        bs4Dash::dropdownMenu(type = "notifications", badgeStatus = NULL,
                              icon = icon("envelope", lib = "font-awesome"),
                              headerText = "Contact us !",
                              bs4Dash::notificationItem(text = "Click here to reach us",
                                                        href = "www.google.com", # defined in utils_helpers.R
                                                        icon = icon("envelope", lib = "font-awesome"), status = "info")
        )
      )
    ),
    sidebar = dashboardSidebar(),
    controlbar = dashboardControlbar(),
    footer = dashboardFooter(),
    title = "dropdownMenu",
    body = dashboardBody()
  ),
  server = function(input, output) {

  }
)
}

Thanks for this great package !

@DivadNojnarg DivadNojnarg added the fixed-in-dev Fixed in development version label Nov 26, 2022
@DivadNojnarg
Copy link
Member

Fixed in dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev Fixed in development version
Projects
None yet
Development

No branches or pull requests

2 participants