Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Launches Not in Light or Dark Mode But Inbetween #302

Closed
ApexHeel opened this issue Aug 22, 2022 · 2 comments
Closed

App Launches Not in Light or Dark Mode But Inbetween #302

ApexHeel opened this issue Aug 22, 2022 · 2 comments
Labels
fixed-in-dev Fixed in development version

Comments

@ApexHeel
Copy link

Issue: Using the simple example version from the documentation and no further customization, the app launches with the sidebar in dark mode and the body in light mode. Toggling the light/dark mode switch fixes it (body changes to dark, toggle again and both change to light).

Expected behavior: App should launch in light mode not a mix of both.

`library(shiny)
library(bs4Dash)

shinyApp(
ui = dashboardPage(
header = dashboardHeader(
title = dashboardBrand(
title = "My dashboard",
color = "primary",
href = "https://adminlte.io/themes/v3",
image = "https://adminlte.io/themes/v3/dist/img/AdminLTELogo.png"
)
),
sidebar = dashboardSidebar(),
body = dashboardBody(
lapply(getAdminLTEColors(), function(color) {
box(status = color)
})
),
controlbar = dashboardControlbar(),
title = "DashboardPage"
),
server = function(input, output) { }
)`

@DivadNojnarg
Copy link
Member

Hi. This is the default AdminLTE behavior (also like shinydashboard which does not have dark mode, except through shinydashboardPlus): https://adminlte.io/themes/v3/. I believe this is to provide more contrast with the body. I need to ask the community whether this change is necessary.

@ApexHeel
Copy link
Author

My thinking is that since the light/dark toggle is present by default and when you toggle to light all switches to light and vice versa with dark that the default presence of all should not be a mix since you can never get back to that if you ever touch the toggle.

@DivadNojnarg DivadNojnarg added the fixed-in-dev Fixed in development version label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev Fixed in development version
Projects
None yet
Development

No branches or pull requests

2 participants