From ed44f0e71520313ff2be46e23b43a01577fd7c10 Mon Sep 17 00:00:00 2001 From: Sebastian Rodriguez Date: Tue, 7 May 2024 13:11:23 -0300 Subject: [PATCH] Added visualization descriptions. Exposed Xmla properties on the Dimension and Measure columns --- .../Visualizations/Primitives/DimensionColumn.cs | 5 ++--- .../Visualizations/Primitives/MeasureColumn.cs | 5 ++--- src/Reveal.Sdk.Dom/Visualizations/Visualization.cs | 5 +++++ 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/Reveal.Sdk.Dom/Visualizations/Primitives/DimensionColumn.cs b/src/Reveal.Sdk.Dom/Visualizations/Primitives/DimensionColumn.cs index 12b4826e..f16e2a3e 100644 --- a/src/Reveal.Sdk.Dom/Visualizations/Primitives/DimensionColumn.cs +++ b/src/Reveal.Sdk.Dom/Visualizations/Primitives/DimensionColumn.cs @@ -21,8 +21,7 @@ public DimensionColumn(IDimensionDataField dataField) : this() [JsonProperty("SummarizationField")] public IDimensionDataField DataField { get; set; } - //todo: implement - [JsonProperty] - internal XmlaDimensionElement XmlaElement { get; set; } + [JsonProperty("XmlaElement")] + public XmlaDimensionElement XmlaElement { get; set; } } } diff --git a/src/Reveal.Sdk.Dom/Visualizations/Primitives/MeasureColumn.cs b/src/Reveal.Sdk.Dom/Visualizations/Primitives/MeasureColumn.cs index a1078142..8e28c979 100644 --- a/src/Reveal.Sdk.Dom/Visualizations/Primitives/MeasureColumn.cs +++ b/src/Reveal.Sdk.Dom/Visualizations/Primitives/MeasureColumn.cs @@ -21,8 +21,7 @@ public MeasureColumn(NumberDataField dataField) : this() [JsonProperty("SummarizationField")] public NumberDataField DataField { get; set; } - //todo: implement - [JsonProperty] - internal XmlaMeasure XmlaMeasure { get; set; } + [JsonProperty("XmlaMeasure")] + public XmlaMeasure XmlaMeasure { get; set; } } } \ No newline at end of file diff --git a/src/Reveal.Sdk.Dom/Visualizations/Visualization.cs b/src/Reveal.Sdk.Dom/Visualizations/Visualization.cs index f8f8b746..bbf83ad4 100644 --- a/src/Reveal.Sdk.Dom/Visualizations/Visualization.cs +++ b/src/Reveal.Sdk.Dom/Visualizations/Visualization.cs @@ -68,6 +68,11 @@ protected Visualization(string title, DataSourceItem dataSourceItem) [JsonProperty("DataSpec", Order = 6)] public IDataDefinition DataDefinition { get; internal set; } + /// + /// Gets or sets the description of the visualization. + /// + public string Description { get; set; } + /// /// Gets the data source item for the visualization. ///