James 2156 #1
Open
James 2156 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithTime success case is strictly equivalent to the success case
This needs to be done by wrapping all references to this trait as private
We can leverage stage sharing through generics. Note that also uncouple stages from each others (to define stage 1, I don't need to know stage 2, only the builder method defining the stage chain needs that) which is a very nice benefit! Note that alternative choices are implemented using default methods.
This constant was only used by tests and made the API confusing. Refactoring this was easy.
Classes go first, then constants, then methods. Note that I inlined a short method that was not related to the API. This avoids poluting the API with useless methods
The difference between them was subtil (resolved/unresolved) and prooved to be confusing. Hence I propose a better method naming for solving this issue.
This class is going to be removed later in that PR
Tests proved to be unstable. After investigation this is a Reactor related bug.
…nt don't require quota feature
…s is not well done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.