-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move close button? #102
Comments
@svanlaere Interesting question; I think you might well be correct. I shall check and if this is the case will change the content order to match read order. |
How can I contact you by e-mail? |
@svanlaere I'd like to keep all conversations public if that's ok. More helpful for others. |
@svanlaere I've updated this in the v5-dev branch. The button can now be placed before and after. |
So can this issue be closed now? |
Not until I release the thing I'd say. |
Been a long time :D |
Perhaps not a real issue, but consider the markup for displaying alerts:
http://responsivebp.com/css/alerts/
Assuming that screenreaders read the button first instead of the more important message:
Would it not make more sence to move the close button after the desired message?
The text was updated successfully, but these errors were encountered: