forked from mpaland/printf
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cplus ize printf #6
Open
fromage17
wants to merge
60
commits into
master
Choose a base branch
from
cplus-ize-printf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…err in Makefile to stop hiding compiler errors
…n non-const math funcs (e.g., log())
…to REQUIRE() on many tests
…s, incl clang-tidy and cppcheck
Martin, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Martin, this PR (cplus-ize-printf) has been updated and now supersedes the other PR (fix-clang-tidy-notifs).
It contains:
a) it contains consts/constexprs for all magic #s, and provides the formulas that underlie computation of the exponent;
b) it addresses all your feedback from PR fix-clang-tidy-notifs;
c) it contains various bug fixes to floating point representations, especially %g use cases;
d) it eliminates an infinite-recursion risk that had been present;
e) it passes all Test Cases, clang-tidy, and cppcheck -- and I added many floating-point Test Cases;
f) it contains the RespiraWorks pre-commit checks;
With your permission, I'll close the old PR (fix-clang-tidy-notifs). This current PR supersedes it.
Here's what's next, as I see it:
Looking forward to your feedback!