Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding developing the reproschma section to readme #523

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

djarecka
Copy link
Member

@yibeichan - take a look if this is what you had in mind

Copy link
Contributor

@yibeichan yibeichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! made some comments there, there is one sentence that I'm not fully understand. and some new lines that were not supposed to be there, probably some formatting errors

and then manually curated in order to support all the reproschema feature.

### Release
Upon release, there are additional formats, `jsonsld`, `turtle`, `n-triples`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Upon release, there are additional formats, jsonsld, turtle, n-triples
and pydantic that are created using LinkML tools, reproschema-py,
and reproschema-specific script for the pydantic format."
a bit confused by this sentence. jsonsld, turtle, n-triples
and pydantic are created from LinkML. and "reproschema-py,
and reproschema-specific script for the pydantic format." what is this part?

## Developing ReproSchema

As of release 1.0.0, a linked data modeling language, [LinkML](https://linkml.io/linkml/), is used to create
a [YAML file](linkml-schema/reproschema.yaml) with the schema.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was supposed to be the same line as line 24 right?

README.md Outdated
### Release
Upon release, there are additional formats, `jsonsld`, `turtle`, `n-triples`
and `pydantic` that are created using `LinkML` tools, `reproschema-py`,
and reproschema-specific script for the `pydantic` format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not supposed to be a new line either


### Updating model in reproschema-py
Another GitHub Action Workflow: [ Create Pull Request to reproschema-py](.github/workflows/push_reproschema_py.yml)
is responsible for creating pull request to the `reproschema-py` Python library with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a new line

### Updating model in reproschema-py
Another GitHub Action Workflow: [ Create Pull Request to reproschema-py](.github/workflows/push_reproschema_py.yml)
is responsible for creating pull request to the `reproschema-py` Python library with
the new version of pydantic model and context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a new line

@djarecka djarecka merged commit 3a30949 into ReproNim:release-prep Jun 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants