Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiometric Scale Factor Off By a Factor? #36

Closed
benjamin-heasly opened this issue Nov 12, 2015 · 1 comment
Closed

Radiometric Scale Factor Off By a Factor? #36

benjamin-heasly opened this issue Nov 12, 2015 · 1 comment

Comments

@benjamin-heasly
Copy link
Contributor

Renderer plugins apply a renderer-specific radiometric scale factor to renderings to bring multi-spectral images into units of radiance. The scale factors are computed with a utility that analyzes the results of a test scene.

We may need to update the utility to remove a factor of two, which we may have included by accident.

The correct conversion involves irradiance for a point at distance, which may be converted to radiance by:

irradiance = pi * radiance (correct)

It may be that we are using this incorrect conversion instead:

irradiance = 2pi * radiance (are we doing this by accident?)

So we should check our code and documentation to see if we need to make a correction:

  • in code, including existing renderer plugins, utilities, and example scenes
  • in our methods paper?
  • on our wiki?

This issue is about determining whether we have an error at all. If we do, we can make a separate issue about correcting it.

@benjamin-heasly
Copy link
Contributor Author

Closing this for RenderToolbox3. Please see new issue at RenderToolbox4:
RenderToolbox/RenderToolbox4#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant