Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build on macOS M1 #177

Open
MiaZhengLS opened this issue Oct 8, 2023 · 4 comments
Open

Failed to build on macOS M1 #177

MiaZhengLS opened this issue Oct 8, 2023 · 4 comments

Comments

@MiaZhengLS
Copy link

image

It seems that it can't find "rtlightmap_hdr.tza" file, but it sits exactly here:

image

P.S. I got these files from manual downloading. Somehow git lfs isn't able to pull these files from upstream.

@atafra
Copy link
Collaborator

atafra commented Oct 10, 2023

The issue is something else based on your screenshot: Python is not found. I just tried cloning the repo and git lfs worked fine. Maybe there was a temporary issue with GitHub. I cannot reproduce the build issue with this freshly cloned copy on an Apple silicon Mac. Could you share what version of CMake and macOS are you using?

@MiaZhengLS
Copy link
Author

Thanks for the response!

Actually the "python isn't found" issue already occurred when I tried to execute cmake. I had to tweak the command to
cmake ..
-DPYTHON_INCLUDE_DIR=$(python -c "from distutils.sysconfig import get_python_inc; print(get_python_inc())")
-DPYTHON_LIBRARY=$(python -c "import distutils.sysconfig as sysconfig; print(sysconfig.get_config_var('LIBDIR'))")
-DPYTHON_EXECUTABLE:FILEPATH=which python

, otherwise it will throw Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE). FYI I found this solution here https://stackoverflow.com/a/48241814. Even though I'm not 100% sure if this really solves the issue since I still got warnings in executing the aforementioned command.
image

python3 works on my machine and it resides in /usr/bin/python3.

Another two things I'm not sure if they're correlated with the issue:

  • I created a fork from this repo and cloned the fork to my local machine.
  • I executed git lfs init and tried other git lfs commands (after I found nothing is in the weights folder) after I cloned with the normal git command.

@MiaZhengLS
Copy link
Author

MiaZhengLS commented Oct 10, 2023

I just removed build folder and retried solely cmake .. to get this screenshot.
image

Even after I set python as alias of python3 to make the command recognized by terminal
image

@atafra
Copy link
Collaborator

atafra commented Oct 12, 2023

I could reproduce the issue if Homebrew with its own Python wasn't installed. This has been fixed in v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants