Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type not aligned #39

Open
KKKLeon opened this issue Jul 1, 2024 · 1 comment
Open

Data type not aligned #39

KKKLeon opened this issue Jul 1, 2024 · 1 comment

Comments

@KKKLeon
Copy link

KKKLeon commented Jul 1, 2024

Dear author, during training the data type of img embedding is float16, but the input type for llama is bf16, I am wondering if this misalignment leads to data precision loss during training? Since float16 is much more precise than bf16.

@RenShuhuai-Andy
Copy link
Owner

Hi, thanks for your interest.

I thinks it's ok to use fp16 for img embedding since it can reduce GPU memory, and it's a common practice for other MLLMs like video-llama. However, it would be possiable to improve performance by using bf16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants