Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This Repo is Now Deprecated #332

Open
RehanSaeed opened this issue Oct 3, 2023 · 5 comments
Open

This Repo is Now Deprecated #332

RehanSaeed opened this issue Oct 3, 2023 · 5 comments

Comments

@RehanSaeed
Copy link
Owner

RehanSaeed commented Oct 3, 2023

This repository is now deprecated. Serilog now has the native ability to log span related data. See serilog/serilog#1955.

@RehanSaeed RehanSaeed added bug Issues describing a bug or pull requests fixing a bug. and removed bug Issues describing a bug or pull requests fixing a bug. labels Oct 3, 2023
@rmorrin
Copy link

rmorrin commented Oct 4, 2023

Can you provide guidance on how to migrate from Serilog.Enrichers.Span to the new Serilog-native equivalent?

It's not clear from reading the attached PR comments what steps are required, if any!

@nblumhardt
Copy link

The Serilog libraries are still a couple of months away from stabilizing, and there aren't any docs out there just yet. It's probably best to stick with this package in the meantime unless you have a strong reason to make the switch (happy to help if so!).

@RehanSaeed
Copy link
Owner Author

RehanSaeed commented Oct 5, 2023

@rmorrin Serilog version 3.1 (unreleased at the time of writing) is most likely to contain the new span API's. Switching would be as simple as removing Serilog.Enrichers.Span and upgrading to Serilog to 3.1 and any other enrichers/sinks.

I will make this clearer in the ReadMe.

@Sebazzz
Copy link

Sebazzz commented Nov 15, 2023

Serilog.Extensions.Logging (which implements ILoggingFactory) indeed does provide SpanId and TraceId on LogEvent, however, nothing like ParentSpanId and SpanStart or similar is being enriched or added. Therefore, this library still has its use.

@nblumhardt
Copy link

@Sebazzz are you currently using this library with a back-end that can use span start/parent span id to display the events hierarchically? (Exploring this space currently... :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants