Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc51 breaking change #1573

Closed
hotrush opened this issue Apr 9, 2021 · 8 comments
Closed

rc51 breaking change #1573

hotrush opened this issue Apr 9, 2021 · 8 comments
Assignees

Comments

@hotrush
Copy link

hotrush commented Apr 9, 2021

Just letting you know that rc51 brings breaking changes when using spec-url

<redoc spec-url='some-url-that-returns-json' hide-download-button="false"></redoc>

image

@eirikur-grid
Copy link

Noticed this as well.
Pinning rc.50 circumvents this issue. The source URL for rc.50 is https://cdn.jsdelivr.net/npm/[email protected]/bundles/redoc.standalone.js

@hotrush
Copy link
Author

hotrush commented Apr 9, 2021

@eirikur-grid yes, switched to rc50, but still - needed to fix this in prod asap 😞 will be glad to see backward compatibility for changes like that

@RomanHotsiy
Copy link
Member

Update:

The issue is caused by the fact your openapi definition endpoint doesn't return the correct mime type for the yaml file and the URL itself doesn't end with .yml, .yaml or .json extension.

We're working on a fix but a temporary workaround would be to either add the Content-Type header or add an extension to the url.

@eirikur-grid
Copy link

We are using starlette's OpenAPIResponse.
It has a content type of "application/vnd.oai.openapi" as per OAI/OpenAPI-Specification#110 (comment)

@RomanHotsiy
Copy link
Member

Thanks for the details. We'll add support for this mime-type too.

@RomanHotsiy
Copy link
Member

This should be fixed on rc.52. Could anybody confirm, please? Thanks in advance!

@eirikur-grid
Copy link

Confirmed.
Screenshot 2021-04-10 at 12 58 01

@RomanHotsiy
Copy link
Member

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants