Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Web interface isn't accessibility friendly #1279

Open
9 of 15 tasks
lornajane opened this issue May 29, 2020 · 11 comments
Open
9 of 15 tasks

Tracking: Web interface isn't accessibility friendly #1279

lornajane opened this issue May 29, 2020 · 11 comments
Labels
a11y Accessibility-related issues

Comments

@lornajane
Copy link
Contributor

lornajane commented May 29, 2020

I'm looking at ReDoc v2 (nice job by the way) but I'm running into problems where the interface isn't very accessible. Looking at the "Accessibility" tab in Firefox, it's mostly div and span tags with onClick events attached that are tripping me up. In order to be useful to more people (and for us to potentially adopt this at work), it would be great to review these and see if some of them could be implemented with some alternative markup or made focusable with tabindex.

Work items

@RomanHotsiy
Copy link
Member

Hey @lornajane! Thanks for the issue!

We are all in to make Redoc v2 more accessible!

Would it help to have separate issues for the different occurrences? I don't want to spam the issue queue if that's not appropriate!

Open different issues! Just make sure to group similar issues into one 😄

@RomanHotsiy RomanHotsiy changed the title Web interface isn't accessibility friendly Tracking: Web interface isn't accessibility friendly May 29, 2020
@RomanHotsiy
Copy link
Member

Let's use this issue as umbrella for all the further issues. Just edit your initial comment.

@adamaltman
Copy link
Member

Is this done @RomanHotsiy?

@RomanHotsiy
Copy link
Member

RomanHotsiy commented Jul 25, 2020

@adamaltman, note this is a tracking issue. We will add more items here when discovered.

But all the current ones are fixed already on version 2.0.0-rc.35.

@lornajane would be great to get your feedback!

@lornajane
Copy link
Contributor Author

Oh this is making such a big difference already! Thanks, people! There are definitely more things that I can see but not click on, I'll add to the list

@RomanHotsiy
Copy link
Member

Hey @lornajane, we've fixed all the newly reported issues. Could you check this out again and provide any extra feedback?

Thanks!

@lornajane
Copy link
Contributor Author

Sure, what's the best way to use a local branch with a custom spec? I had a look a few weeks ago but I'm not a frontender and it wasn't clear to me how to build a bleeding-edge or other-branch version of the thing I include in my html page to render specs (or is the CLI ready enough for an unskilled person to use at this point? That's how I used v1)

... let me know if we should track this in a separate issue or other location for discussion not about accessibility?

@RomanHotsiy
Copy link
Member

You can use our demo page https://redocly.github.io/redoc/ or use TL;DR section from the README and replace spec-url with your definition URL: https://github.com/Redocly/redoc#tldr. Use 2.0.0-rc.36.

Also, the latest redoc-cli should be good too. Make sure to use [email protected]

@lornajane
Copy link
Contributor Author

I can use the most recent releases but I would like to know how to use my local clone with a local spec as well if possible - then I'd be able to test a branch

@lornajane
Copy link
Contributor Author

Everything marked as complete is working perfectly now! I am definitely adopting redoc as my everyday local tool :) I did find and capture a couple of other things while I was testing a different spec today.

@r3sdev
Copy link

r3sdev commented Apr 25, 2022

Hi, are there any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility-related issues
Projects
None yet
Development

No branches or pull requests

4 participants