fix: use labelled arguments instead of functors #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favonia
force-pushed
the
collapse-functor
branch
from
01e7fd2
to
626dd97
Compare
favonia
force-pushed
the
collapse-functor
branch
from
626dd97
to
6bb803f
Compare
jonsterling
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Thought of using labelled arguments.
The main thing I am not sure of is that handlers are optional to
Modifier.runin this PR---by default, it would simply ignore all the algebraic effects. (That is, shadowing will be silent, "name not found" will be ignored, and hooks are skipped.) Is it a good design to allow users to omit those handlers and default to the "silencing" handlers? The obvious alternative is to make them mandatory.