Check the response from the database query sooner in the response-con…

…sumer
RedHatInsights · Dec 4, 2024 · 78786e5 · 78786e5
1 parent 2e447b4
commit 78786e5
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/internal/response-consumer/handler.go b/internal/response-consumer/handler.go
@@ -83,6 +83,15 @@ func (this *handler) onMessage(ctx context.Context, msg *k.Message) {
 
 		selectResult := baseQuery.Select("id", "status", "response_full").First(&run)
 
+		if selectResult.Error != nil {
+			if errors.Is(selectResult.Error, gorm.ErrRecordNotFound) {
+				return nil
+			}
+
+			utils.GetLogFromContext(ctx).Errorw("Error fetching run from db", "error", selectResult.Error)
+			return selectResult.Error
+		}
+
 		if requestType == satMessageHeaderValue {
 			satellite.SortSatEvents(value.SatEvents)
 
@@ -101,15 +110,6 @@ func (this *handler) onMessage(ctx context.Context, msg *k.Message) {
 			eventsSerialized = utils.MustMarshal(value.RunnerEvents)
 		}
 
-		if selectResult.Error != nil {
-			if errors.Is(selectResult.Error, gorm.ErrRecordNotFound) {
-				return nil
-			}
-
-			utils.GetLogFromContext(ctx).Errorw("Error fetching run from db", "error", selectResult.Error)
-			return selectResult.Error
-		}
-
 		toUpdate := db.Run{
 			Status: status,
 			Events: eventsSerialized,