Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InventoryGroupDetails): THEEDGE-3707 implement edge group details expostion #2092

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Nov 14, 2023

Implements https://issues.redhat.com/browse/THEEDGE-3707

this commit expose edge group details component from edge,
and give the ability if important customer log in to the system and navigate to group details screen from edge group screen, he will see edge group list instead of inventory and then be able to open group details

@mgold1234 mgold1234 requested a review from a team as a code owner November 14, 2023 12:30
@codecov-commenter
Copy link

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (910cb2c) 59.15% compared to head (7cea6a0) 58.85%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Utilities/hooks/useEdgeGroups.js 10.00% 9 Missing ⚠️
src/Routes.js 0.00% 7 Missing ⚠️
src/api/api.js 25.00% 3 Missing ⚠️
...omponents/InventoryGroupDetail/EdgeGroupDetails.js 25.00% 3 Missing ⚠️
src/components/InventoryGroups/EdgeGroups.js 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
- Coverage   59.15%   58.85%   -0.30%     
==========================================
  Files         183      186       +3     
  Lines        5846     5882      +36     
  Branches     1656     1661       +5     
==========================================
+ Hits         3458     3462       +4     
- Misses       2388     2420      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgold1234 mgold1234 marked this pull request as draft November 15, 2023 10:25
@gkarat gkarat added the enhancement New feature or request label Nov 21, 2023
@mgold1234 mgold1234 force-pushed the expose_details branch 2 times, most recently from b68a877 to a354c2c Compare November 22, 2023 12:47
@mgold1234 mgold1234 marked this pull request as ready for review November 22, 2023 12:52
Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please consider some minor suggestions, otherwise the PR looks good, tried locally with enforced and normal accounts

src/routes/InventoryOrEdgeGroupDetailsComponent.js Outdated Show resolved Hide resolved
src/routes/InventoryOrEdgeGroupDetailsComponent.js Outdated Show resolved Hide resolved
@gkarat gkarat enabled auto-merge (squash) November 24, 2023 10:32
@gkarat gkarat merged commit e884521 into RedHatInsights:master Nov 24, 2023
2 checks passed
@gkarat
Copy link
Contributor

gkarat commented Nov 24, 2023

🎉 This PR is included in version 1.59.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants