Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-9709): Add available image to bootc card #2182

Merged
merged 1 commit into from
May 1, 2024

Conversation

dkuc
Copy link
Contributor

@dkuc dkuc commented Apr 25, 2024

Adds available image and available image hash.
image

@dkuc dkuc requested a review from a team as a code owner April 25, 2024 14:20
@dkuc dkuc force-pushed the bootc_available_image branch from 14c066b to 62a1ba3 Compare April 25, 2024 18:32
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (a02da2c) to head (2f7ea81).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2182      +/-   ##
==========================================
+ Coverage   57.04%   57.14%   +0.09%     
==========================================
  Files         207      207              
  Lines        6400     6403       +3     
  Branches     1785     1788       +3     
==========================================
+ Hits         3651     3659       +8     
+ Misses       2749     2744       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bastilian
Copy link
Member

@dkuc Can we please add a test for this component? I would recommend the BiosCard test as a base, as it is the most basic.

@dkuc dkuc changed the title Add available image to bootc card feat(RHINENG-9709): Add available image to bootc card Apr 26, 2024
@dkuc dkuc force-pushed the bootc_available_image branch from 62a1ba3 to c658db7 Compare April 26, 2024 16:47
@dkuc
Copy link
Contributor Author

dkuc commented Apr 26, 2024

@dkuc Can we please add a test for this component? I would recommend the BiosCard test as a base, as it is the most basic.

Done.

@dkuc dkuc force-pushed the bootc_available_image branch 2 times, most recently from 6663afb to c315950 Compare April 26, 2024 17:03
@bastilian
Copy link
Member

/retest

Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dkuc! LGTM!

@dkuc dkuc force-pushed the bootc_available_image branch from c315950 to 2f7ea81 Compare April 30, 2024 19:59
@dkuc
Copy link
Contributor Author

dkuc commented Apr 30, 2024

Just fyi, I don't have merge permissions.

@bastilian bastilian merged commit 212c1d8 into RedHatInsights:master May 1, 2024
2 checks passed
@gkarat
Copy link
Contributor

gkarat commented May 1, 2024

🎉 This PR is included in version 1.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants