Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-9686): Add system table toggle details #2180

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

johnsonm325
Copy link
Contributor

Add "View by" text to the left of system table toggle on the Systems table page header. Each toggle button should have tooltips.

@johnsonm325 johnsonm325 requested a review from a team as a code owner April 24, 2024 17:36
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.05%. Comparing base (9f6dc03) to head (7c6b875).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2180      +/-   ##
==========================================
- Coverage   57.08%   57.05%   -0.04%     
==========================================
  Files         207      207              
  Lines        6396     6396              
  Branches     1782     1782              
==========================================
- Hits         3651     3649       -2     
- Misses       2745     2747       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leSamo
Copy link
Member

leSamo commented Apr 25, 2024

/retest

Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! The only thing I noticed is that after these changes toggle buttons have unexpected border radius. It is not visible unless you look closely. It would maybe better to fix this before merging.

image

Michael Johnson added 2 commits April 26, 2024 11:28
Add "View by" text to the left of system table toggle on the Systems table page header. Each toggle button should have tooltips.
@johnsonm325 johnsonm325 merged commit e17bbd1 into RedHatInsights:master Apr 26, 2024
2 checks passed
@gkarat
Copy link
Contributor

gkarat commented Apr 26, 2024

🎉 This PR is included in version 1.71.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants