Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-8372): Fix Group details not loading Edge devices #2155

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Mar 1, 2024

Fixes https://issues.redhat.com/browse/RHINENG-8372.

The Immutable tab was playing up because of the deviceData being undefined or null which was not treated as a separate edge case.

How to test

  1. Have a group with both conventional and immutable systems
  2. Navigate to this group
  3. Make sure you can switch between both immutable and conventional systems tabs without crash (which is reproducible on stage)

Fixes https://issues.redhat.com/browse/RHINENG-8372.

The Immutable tab was playing up because of the deviceData being undefined or null which was not treated as a separate edge case.
@gkarat gkarat added the bug Something isn't working label Mar 1, 2024
@gkarat gkarat self-assigned this Mar 1, 2024
@gkarat gkarat requested a review from a team as a code owner March 1, 2024 11:14
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.90%. Comparing base (a230a96) to head (a7fb7cd).

Files Patch % Lines
...c/components/GroupSystems/GroupImmutableSystems.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2155      +/-   ##
==========================================
- Coverage   42.91%   42.90%   -0.01%     
==========================================
  Files         196      196              
  Lines        6273     6274       +1     
  Branches     1751     1752       +1     
==========================================
  Hits         2692     2692              
- Misses       3581     3582       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! opening a group detail page works for both conventional and immutable tabs

@gkarat gkarat merged commit 3fe1733 into RedHatInsights:master Mar 1, 2024
2 checks passed
@gkarat gkarat deleted the rhineng-8372 branch March 1, 2024 12:13
@gkarat
Copy link
Contributor Author

gkarat commented Mar 1, 2024

🎉 This PR is included in version 1.64.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants