Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-7744): fix status column default value in Immutable tabs #2142

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

mkholjuraev
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/RHINENG-7744

Displays 'unknown' status for devices that are not properly uploaded.

@mkholjuraev mkholjuraev requested a review from a team as a code owner February 1, 2024 14:17
@mkholjuraev mkholjuraev marked this pull request as draft February 1, 2024 14:17
@mkholjuraev mkholjuraev marked this pull request as ready for review February 6, 2024 09:37
@gkarat gkarat added the bug Something isn't working label Feb 7, 2024
Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (05b10bf) 57.14% compared to head (8498370) 57.14%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Utilities/TestingUtilities.js 88.88% 1 Missing ⚠️
...components/ImmutableDevices/ImmutableDevices.cy.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2142   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files         194      195    +1     
  Lines        6246     6261   +15     
  Branches     1743     1748    +5     
=======================================
+ Hits         3569     3578    +9     
- Misses       2677     2683    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkholjuraev mkholjuraev merged commit 3509818 into RedHatInsights:master Feb 7, 2024
2 checks passed
@gkarat
Copy link
Contributor

gkarat commented Feb 7, 2024

🎉 This PR is included in version 1.64.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants