fix(RHINENG-2392): Show refresh link in group notifications #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
force-pushed
the
rhineng-2392
branch
2 times, most recently
from
fe60bf3 to
71cc971
Compare
Fixes https://issues.redhat.com/browse/RHINENG-2392. This adds a refresh link to the success notification when systems are added or removed from a group. The data is no longer reloaded automatically.
|
/retest |
adonispuente
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Same IQE test is failing on this one , ERROR at setup of test_navigate_to_groups, but the PR itself looks good to me. I dont believe that failure is related to this PR.
Just as a side note, we already reload the page when we add a system, do we want this notification to appear with the refresh option even though we already preform the action?
|
@adonispuente, the automatic refresh on adding systems will go away soon (see my caption in the description) because it still can provide inconsistent results 🙂 |
|
🎉 This PR is included in version 1.62.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/RHINENG-2392.
This adds a refresh link to the success notification when systems are added or removed from a group. The data is no longer reloaded automatically due to possible inconsistency in the results.
How to test
Screenshots