fix(THEEDGE-3757): add validation to imageset #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
…-frontend into THEEDGE-3757-fix-scalprum-error
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2122 +/- ##
==========================================
- Coverage 57.59% 57.47% -0.13%
==========================================
Files 193 193
Lines 6198 6198
Branches 1717 1717
==========================================
- Hits 3570 3562 -8
- Misses 2628 2636 +8 ☔ View full report in Codecov by Sentry. |
|
/retest |
LiorKGOW
suggested changes
Dec 13, 2023
| @@ -187,7 +187,7 @@ const GroupImmutableSystems = ({ groupName, groupId, ...props }) => { | |||
|
|
|||
| //enable disable bulk update based on selection, must refactor | |||
| useEffect(() => { | |||
| if (selected.size > 0) { | |||
| if (selected.size > 0 && deviceImageSet?.size > 0) { | |||
There was a problem hiding this comment.
Shouldn't deviceImageSet be added as a dependency to the useEffect's dependency array ? 🤔
The condition could change when it is changed, which would effect the Effect
There was a problem hiding this comment.
@LiorKGOW included the validation on useEffect but I kept the condition cause we should not get in this validation if there is no imageSet
…-frontend into THEEDGE-3757-fix-scalprum-error
LiorKGOW
previously approved these changes
Dec 15, 2023
LiorKGOW
approved these changes
Dec 15, 2023
|
🎉 This PR is included in version 1.62.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix validation to avoid exception for navigate.
Check if deviceImageSet is filled before find the imae value