fix(THEEDGE-3739): Fix filter and link to device details #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acosferreira
changed the title
acosferreira
changed the title
acosferreira
force-pushed
the
THEEDGE-3739-fix-link-and-filter
branch
from
7519324 to
e6e2c87
Compare
acosferreira
force-pushed
the
THEEDGE-3739-fix-link-and-filter
branch
from
e6e2c87 to
0314a0c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2112 +/- ##
==========================================
+ Coverage 57.41% 57.49% +0.07%
==========================================
Files 193 193
Lines 6181 6192 +11
Branches 1712 1713 +1
==========================================
+ Hits 3549 3560 +11
Misses 2632 2632 ☔ View full report in Codecov by Sentry. |
…-frontend into THEEDGE-3739-fix-link-and-filter
|
/retest |
1 similar comment
|
/retest |
mkholjuraev
reviewed
Dec 4, 2023
| total: customResult?.data?.total, | ||
| }; | ||
| let mapDeviceIds = []; | ||
| defaultData.results.forEach((data) => { |
There was a problem hiding this comment.
It would be great if we could extract this portion of code that fetches and merges data. Furthermore, with coverage tests, we would make sure of its behaviour.
…-frontend into THEEDGE-3739-fix-link-and-filter
mkholjuraev
approved these changes
Dec 12, 2023
|
/restest |
|
/retest |
1 similar comment
|
/retest |
gkarat
added
enhancement
|
🎉 This PR is included in version 1.61.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the filter and link on immutable tab for group details.
https://issues.redhat.com/browse/THEEDGE-3739