Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-1423): Enable sorting by last modified #2106

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Nov 22, 2023

Fixes https://issues.redhat.com/browse/RHINENG-1423.

Adds sorting by last modified on the groups page.

How to test

  1. Go to /inventory/groups
  2. Try to sort some groups by the "Last modified" column, verify that the results are correct
  3. Make sure the sorting persists after page refresh

@gkarat gkarat added the bug Something isn't working label Nov 22, 2023
@gkarat gkarat self-assigned this Nov 22, 2023
@gkarat gkarat requested a review from a team as a code owner November 22, 2023 16:08
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (198049d) 59.29% compared to head (fdcd0b6) 59.26%.

Files Patch % Lines
src/components/GroupsTable/GroupsTable.cy.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
- Coverage   59.29%   59.26%   -0.04%     
==========================================
  Files         186      186              
  Lines        5918     5921       +3     
  Branches     1665     1665              
==========================================
  Hits         3509     3509              
- Misses       2409     2412       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorting works as expected on last modified column.

@gkarat gkarat merged commit b0ec242 into RedHatInsights:master Nov 22, 2023
2 checks passed
@gkarat
Copy link
Contributor Author

gkarat commented Nov 22, 2023

🎉 This PR is included in version 1.57.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants