fix(ESSNTL-5418): Trim group name before validate #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2105 +/- ##
==========================================
+ Coverage 59.29% 59.31% +0.01%
==========================================
Files 186 186
Lines 5918 5918
Branches 1665 1665
==========================================
+ Hits 3509 3510 +1
+ Misses 2409 2408 -1 ☔ View full report in Codecov by Sentry. |
mkholjuraev
approved these changes
Nov 23, 2023
| throw 'Group name already exists'; | ||
| } | ||
|
|
||
| return undefined; |
There was a problem hiding this comment.
Question: why would we need to return undefined explicitly?
There was a problem hiding this comment.
This is the requirement of data-driven-forms. In order to mark that the validator succeeds, it shouldn't return nothing or just undefined 😄
|
🎉 This PR is included in version 1.58.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/ESSNTL-5418.
How to test