fix(THEEDGE-3703): On immutable tab we can't see the add system option #2102
Conversation
… add update inline and button
…-frontend into THEEDGE-3703-add-system
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2102 +/- ##
==========================================
- Coverage 59.22% 57.96% -1.27%
==========================================
Files 188 189 +1
Lines 5938 6078 +140
Branches 1669 1700 +31
==========================================
+ Hits 3517 3523 +6
- Misses 2421 2555 +134 ☔ View full report in Codecov by Sentry. |
|
/retest |
…-frontend into THEEDGE-3703-add-system
gkarat
changed the title
| const { uninitialized, loading, data } = useSelector( | ||
| (state) => state.groupDetail | ||
| ); | ||
|
|
||
| return uninitialized || loading ? ( | ||
| <EmptyState> | ||
| <EmptyStateBody> | ||
| <Spinner /> | ||
| </EmptyStateBody> | ||
| </EmptyState> | ||
| ) : (data?.results?.[0]?.host_count || 0) > 0 ? ( |
There was a problem hiding this comment.
Can we double-check that data?.results?.[0]?.host_count also includes the immutable systems? If not, then we have to update the condition here too.
There was a problem hiding this comment.
the results not includes the immutable.
We need explicit pass the filter to get the total of immutable.
There was a problem hiding this comment.
But imagine the scenario: there are 0 conventional systems available, and there is at least one immutable system for this group. In that case, the app will show NoSystemsEmptyState because data?.results?.[0]?.host_count evaluates to 0 even though there are some immutable devices.
There was a problem hiding this comment.
yes, that is the expected behavior.
If there the total of conventional is 0 and immutable > 0 we should open the screen with focus in the immutable tab and the conventional will be empty.
| const { uninitialized, loading, data } = useSelector( | ||
| (state) => state.groupDetail | ||
| ); | ||
|
|
||
| return uninitialized || loading ? ( | ||
| <EmptyState> | ||
| <EmptyStateBody> | ||
| <Spinner /> | ||
| </EmptyStateBody> | ||
| </EmptyState> | ||
| ) : (data?.results?.[0]?.host_count || 0) > 0 ? ( |
There was a problem hiding this comment.
But imagine the scenario: there are 0 conventional systems available, and there is at least one immutable system for this group. In that case, the app will show NoSystemsEmptyState because data?.results?.[0]?.host_count evaluates to 0 even though there are some immutable devices.
…-frontend into THEEDGE-3703-add-system
|
/retest |
|
🎉 This PR is included in version 1.60.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes https://issues.redhat.com/browse/THEEDGE-3703.
As part of this ticket, iwe moved the list of immutable from federation module to insights code, adding the update actions inline and bulk selection based on image_set values.
We also match the mockup from #3581.
Now he have add system, update bulk selection, update inline, add/remove from group and tab list.
THEEDGE-3705.webm