Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Patchman API to v3 #2100

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Update Patchman API to v3 #2100

merged 1 commit into from
Nov 22, 2023

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Nov 20, 2023

https://issues.redhat.com/browse/RHINENG-3395

Patchman v1 and v2 APIs will be turned off on 01/01/2024 so we need to update the version. The new version is backwards compatible (no parameters are removed/changed, only added).

@leSamo leSamo requested a review from a team as a code owner November 20, 2023 23:37
Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 Thanks for doing this ahead of time

Looks like you need to change your commit message like fix(something): message

@gkarat
Copy link
Contributor

gkarat commented Nov 22, 2023

I have spun the tests step (linting is erroring because of bad commit title tho). If it passes, I will squash and merge the PR, thanks @leSamo

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3e7158) 58.93% compared to head (9e20c73) 58.93%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2100   +/-   ##
=======================================
  Coverage   58.93%   58.93%           
=======================================
  Files         183      183           
  Lines        5871     5871           
  Branches     1658     1658           
=======================================
  Hits         3460     3460           
  Misses       2411     2411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gkarat gkarat merged commit 198049d into master Nov 22, 2023
1 of 3 checks passed
@gkarat gkarat deleted the patchman-v3-api branch November 22, 2023 13:47
@gkarat
Copy link
Contributor

gkarat commented Nov 22, 2023

🎉 This PR is included in version 1.57.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants