Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ImmutableDevices): image name should take to image details page #2088

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

mkholjuraev
Copy link
Contributor

This fixes existing bugs when users click on the image name on Immutable devices table. Before this change, it would take users to edge device detail page, after this change users will be taken to image details page in image-builder app.

To test:

  1. run inventory and advisor applications
  2. Open advisor recommendations and select Decreased performance occurs when KVM and VMWare guests are not running with recommended tuned service configuration which has immutable devices.
  3. Click on Image name
  4. Observe that you are taken to image details page in image-builder app

@mkholjuraev mkholjuraev requested a review from a team as a code owner November 10, 2023 12:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/components/ImmutableDevices/columns.js 91.66% <100.00%> (ø)
...components/ImmutableDevices/ImmutableDevices.cy.js 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!

@mkholjuraev mkholjuraev added don't merge Should not be merged at this time. May be blocked, see description. blocker and removed don't merge Should not be merged at this time. May be blocked, see description. labels Nov 13, 2023
Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, good job @mkholjuraev 😄

@mkholjuraev mkholjuraev merged commit 180f925 into RedHatInsights:master Nov 14, 2023
1 check passed
@gkarat
Copy link
Contributor

gkarat commented Nov 14, 2023

🎉 This PR is included in version 1.55.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants