Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Staleness): Update staleness page to match new backend specs #2082

Merged
merged 6 commits into from
Nov 10, 2023
Merged

fix(Staleness): Update staleness page to match new backend specs #2082

merged 6 commits into from
Nov 10, 2023

Conversation

adonispuente
Copy link
Contributor

@adonispuente adonispuente commented Nov 2, 2023 •
edited
Loading

This PR adds an additional check to only send values that have been altered to the api.
It also removes 'unknown' as an option for the status filter.
fix(RHINENG-2911): Update values in staleness api request

fix(ESSNTL-5595): remove unknown option in status filter

ESSNTL-5538: Update RBAC roles & Add buffer to api Values

https://issues.redhat.com/browse/ESSNTL-5605 : [UI] Update custom staleness defaults for edge systems

@adonispuente adonispuente requested a review from a team as a code owner November 2, 2023 15:50
@adonispuente adonispuente changed the title RHIENG-2911 + ESSNTL-5595 fix(Staleness): Update staleness page to match new backend specs Nov 8, 2023
@adonispuente adonispuente requested a review from gkarat November 8, 2023 18:55
@adonispuente
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Utilities/constants.js 80.43% <ø> (ø)
...ts/InventoryHostStaleness/HostStalenessNoAccess.js 0.00% <ø> (ø)
...onents/InventoryHostStaleness/HostStalenessCard.js 60.46% <0.00%> (-0.72%) ⬇️
src/components/InventoryHostStaleness/constants.js 83.97% <54.54%> (-2.03%) ⬇️

📢 Thoughts on this report? Let us know!

@adonispuente
Copy link
Contributor Author

/retest

2 similar comments
@adonispuente
Copy link
Contributor Author

/retest

@computercamplove
Copy link
Contributor

/retest

@gkarat gkarat added the enhancement New feature or request label Nov 10, 2023
@computercamplove
Copy link
Contributor

/retest

gkarat
gkarat approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the PR works just fine, and all the bugs/changes associated with the tickets are resolved. There is a flaky test failure, otherwise everything passes so you can ignore the travis check for now

src/components/InventoryHostStaleness/constants.js
if (seconds === 104400) {
return 1;
} else {
return seconds / 86400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we better have some rounding? In case backend provides malformed data/something goes wrong and we at least provide an integer value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement for this day in particular requires a a buffer, originally this was just one day/86400 seconds, but they want this specific buffer going forward

@computercamplove
Copy link
Contributor

when i click on reset to default on immutable tab i still see old values
image

@adonispuente
Copy link
Contributor Author

@computercamplove those reset values come from the api, Once the backend makes the appropriate changes and sends them to stage, the changes will reflect on the FE

@adonispuente adonispuente merged commit 910cb2c into RedHatInsights:master Nov 10, 2023
1 check passed
@gkarat
Copy link
Contributor

gkarat commented Nov 10, 2023

🎉 This PR is included in version 1.55.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkarat gkarat gkarat approved these changes

Assignees

@adonispuente adonispuente

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adonispuente @codecov-commenter @computercamplove @gkarat