Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(THEEDGE-3581): add tab controls to display detail groups #2079

Merged

Conversation

acosferreira
Copy link
Contributor

This PR add a tab to group details when exists an edge host added to the group.
In case only edge devices the focus will be on immutable
In case only conventional, no tabs displayed

image
image
image

@acosferreira
Copy link
Contributor Author

this PR should be merged after RedHatInsights/edge-frontend#762

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...ntoryTabs/ImmutableDevices/EdgeDevicesGroupView.js 25.00% <25.00%> (ø)
...components/InventoryGroupDetail/GroupTabDetails.js 15.78% <15.78%> (ø)
...nents/InventoryGroupDetail/InventoryGroupDetail.js 64.00% <35.71%> (-36.00%) ⬇️

📢 Thoughts on this report? Let us know!.

@acosferreira acosferreira marked this pull request as ready for review November 2, 2023 14:32
@acosferreira acosferreira requested a review from a team as a code owner November 2, 2023 14:32
Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! While testing locally, I did not face issues.

});
});
} catch (e) {
console.log('>>>> ' + e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('>>>> ' + e);
setHasEdgeImages(false);
setActiveTab(hybridInventoryTabKeys.conventional.key);

@mkholjuraev
Copy link
Contributor

/retest

@mkholjuraev mkholjuraev merged commit 0c8907f into RedHatInsights:master Nov 3, 2023
1 check passed
@gkarat
Copy link
Contributor

gkarat commented Nov 3, 2023

🎉 This PR is included in version 1.55.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants