Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHIF-294): disable sorting on immutable status column #2065

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

mkholjuraev
Copy link
Contributor

Disables sorting on Status column in immutable devices table

@mkholjuraev mkholjuraev requested a review from a team as a code owner October 19, 2023 12:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/components/ImmutableDevices/columns.js 0.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkholjuraev mkholjuraev enabled auto-merge (squash) October 20, 2023 12:35
auto-merge was automatically disabled October 25, 2023 11:16

Pull request was closed

@mkholjuraev mkholjuraev reopened this Oct 25, 2023
@mkholjuraev mkholjuraev enabled auto-merge (squash) October 25, 2023 11:20
@mkholjuraev mkholjuraev force-pushed the immutable-devices branch 2 times, most recently from 37a3f3c to 2215fd1 Compare October 25, 2023 11:30
@mkholjuraev
Copy link
Contributor Author

/retest

2 similar comments
@mkholjuraev
Copy link
Contributor Author

/retest

@mkholjuraev
Copy link
Contributor Author

/retest

@mkholjuraev
Copy link
Contributor Author

/retest

2 similar comments
@mkholjuraev
Copy link
Contributor Author

/retest

@computercamplove
Copy link
Contributor

/retest

@mkholjuraev mkholjuraev merged commit 1d53d5c into RedHatInsights:master Oct 26, 2023
1 check passed
@gkarat
Copy link
Contributor

gkarat commented Oct 26, 2023

🎉 This PR is included in version 1.54.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants