feat(THEEDGE-3585): Allow immutable systems selection in group details empty state #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
from
5b4af72 to
d70baa0
Compare
ldjebran
changed the title
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
from
d70baa0 to
013ae05
Compare
ldjebran
changed the title
ldjebran
changed the title
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
4 times, most recently
from
28c28b4 to
20dd3dd
Compare
bastilian
reviewed
Oct 13, 2023
src/components/InventoryGroups/Modals/AddSystemsToGroupModal.js
Outdated
Show resolved
Hide resolved
mkholjuraev
reviewed
Oct 13, 2023
src/components/InventoryGroups/Modals/AddSystemsToGroupModal.js
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
2 times, most recently
from
c0ea5e3 to
b214de0
Compare
|
@mkholjuraev @bastilian updated and responded to comments, please revisit. |
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
from
b214de0 to
9468c66
Compare
|
resolved conflicts |
mkholjuraev
approved these changes
Oct 16, 2023
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
from
9468c66 to
84ae50c
Compare
|
rebased |
|
/retest |
1 similar comment
|
/retest |
bastilian
reviewed
Oct 17, 2023
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
from
84ae50c to
2ebece9
Compare
|
/retest |
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
from
2ebece9 to
7a238cf
Compare
|
Seems the automation was broken, as was not able to find npm. |
…s view empty state In the context of edgeParity, when creating a new group and selecting that group, we enter the group details view, because it has no systems added yet an empty state is displayed and Add systems button is displayed also to systems, this PR allow to add conventional and immutable systems in that modal view. - This should not affect the main add systems button when systems exists in group that's why edgeParityIsAllowed key is added. - Two feature flags has be taken into considerations 'edgeParity.inventory-list' and 'edgeParity.inventory-groups-enabled'. - If there is no immutable systems the immutable tab is not shown. - Label is added in the header when edgeParity is enabled to show the overall number of the selected systems. - The constraint is also taken into account, when the immutable system has a group to disable adding system and show the warning message. FIXES: https://issues.redhat.com/browse/THEEDGE-3585
ldjebran
force-pushed
the
group-details-empty-add-edge-systems-tab
branch
from
7a238cf to
1216d94
Compare
|
/retest |
|
🎉 This PR is included in version 1.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
acosferreira
pushed a commit
to acosferreira/insights-inventory-frontend
that referenced
this pull request
Oct 24, 2023
…s view empty state (RedHatInsights#2057) In the context of edgeParity, when creating a new group and selecting that group, we enter the group details view, because it has no systems added yet an empty state is displayed and Add systems button is displayed also to systems, this PR allow to add conventional and immutable systems in that modal view. - This should not affect the main add systems button when systems exists in group that's why edgeParityIsAllowed key is added. - Two feature flags has be taken into considerations 'edgeParity.inventory-list' and 'edgeParity.inventory-groups-enabled'. - If there is no immutable systems the immutable tab is not shown. - Label is added in the header when edgeParity is enabled to show the overall number of the selected systems. - The constraint is also taken into account, when the immutable system has a group to disable adding system and show the warning message. FIXES: https://issues.redhat.com/browse/THEEDGE-3585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of edgeParity, when creating a new group and selecting that group we enter the group details view, because it has no systems added yet an empty state is displayed and Add systems button is displayed also to systems, this PR allow to add conventional and immutable systems in that view.
Note: The group details view has no immutable tab for the moment that will be added in another task.
FIXES: https://issues.redhat.com/browse/THEEDGE-3585