Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ESSNTL-5064): Fix groups filter by more values #1946

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Jul 24, 2023

Fixes https://issues.redhat.com/browse/ESSNTL-5064.

This fixes the groups filter in Inventory table: before, we were calling a wrong action, instead, we have to use the one that updates values under entities.

How to test

  1. Go to /inventory
  2. Try to apply the groups filter by more values, wait for refresh, and try again,
  3. The table should show correct data and also update URL parameters accordingly.

@gkarat gkarat added the bug Something isn't working label Jul 24, 2023
@gkarat gkarat self-assigned this Jul 24, 2023
@gkarat gkarat requested a review from a team as a code owner July 24, 2023 11:09
Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkarat gkarat merged commit 02b22fa into RedHatInsights:master Jul 24, 2023
@gkarat
Copy link
Contributor Author

gkarat commented Jul 24, 2023

🎉 This PR is included in version 1.33.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants