fix(ESSNTL-4938): Hide systems count if no hosts:read #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! without hosts:read not able to see Total systems |
|
🎉 This PR is included in version 1.32.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/ESSNTL-4937?focusedId=22605892&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-22605892.
If users don't have
inventory:hosts:read, then the groups table (/groups) must not show number of hosts for each group. "N/A" must be rendered instead. This was broken with https://github.com/RedHatInsights/insights-inventory-frontend/pull/1928/files#diff-8a000812b9df4b6f250a6030383a065b82497add0b572416ef6e92fc4f469b95R132.How to test
Have an account with groups:read but with not hosts:read permissions. Go to /groups and check that all groups have "N/A" in their total systems number.