ESSNTL-4883 - ROS tab not visible in Inventory fix #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1907 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 145 145
Lines 3978 3978
Branches 1129 1129
=======================================
Hits 2596 2596
Misses 1382 1382
☔ View full report in Codecov by Sentry. |
gkarat
approved these changes
Jun 22, 2023
|
@jiridostal Why package-lock is added to this PR? |
mkholjuraev
approved these changes
Jun 22, 2023
PreetiW
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
I tested the PR and ROS tab is now visible in the inventory detail page. Thanks @jiridostal for the fix 🙌🏻
|
🎉 This PR is included in version 1.23.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where Inventory does not display ROS tab correctly based on the cloud provider.