Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ESSNTL-3730): Refresh groups when new created #1857

Merged

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented May 9, 2023

Addresses https://issues.redhat.com/browse/ESSNTL-3730?focusedId=22178599&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-22178599.

Make it possible for the modal ("add host to group") to refresh the list of available groups after users have created the new one.

How to test

  1. Run npm run start:proxy:beta
  2. Navigate to https://stage.foo.redhat.com:1337/preview/insights/inventory
  3. Find any available host and try to open "Add to group" modal
  4. Try to create a new group, submit, then check that you are 1) redirected back to the main modal, 2) the list of available groups contains the group you have just created.
  5. Try to select the new group and submit the modal.
  6. You must get an error (405 error code) - this is expected, but the request should contain the id of the new group and also the id of the selected host.

image

@gkarat gkarat self-assigned this May 9, 2023
@gkarat gkarat requested a review from a team as a code owner May 9, 2023 15:58
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 16.66% and project coverage change: -10.19 ⚠️

Comparison is base (ee69adc) 64.81% compared to head (043c622) 54.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1857       +/-   ##
===========================================
- Coverage   64.81%   54.62%   -10.19%     
===========================================
  Files         136      136               
  Lines        3425     3425               
  Branches     1028     1030        +2     
===========================================
- Hits         2220     1871      -349     
- Misses       1205     1554      +349     
Impacted Files Coverage Δ
...ents/InventoryGroups/Modals/AddHostToGroupModal.js 11.76% <ø> (+2.24%) ⬆️
...nts/InventoryGroups/Modals/ModalSchemas/schemes.js 40.00% <16.66%> (-26.67%) ⬇️

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gkarat
Copy link
Contributor Author

gkarat commented May 10, 2023

/retest

@gkarat gkarat requested a review from Fewwy May 10, 2023 09:23
@gkarat
Copy link
Contributor Author

gkarat commented May 10, 2023

/retest

Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gkarat gkarat merged commit 9488163 into RedHatInsights:master May 10, 2023
@gkarat gkarat deleted the essntl-3730-refresh-groups-list branch May 10, 2023 12:26
@gkarat
Copy link
Contributor Author

gkarat commented May 10, 2023

🎉 This PR is included in version 1.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants