fix(ADIVOSR-3016): Add perPage arg to getEntities #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
- Coverage 70.45% 69.30% -1.16%
==========================================
Files 122 122
Lines 2579 2580 +1
Branches 885 885
==========================================
- Hits 1817 1788 -29
- Misses 762 792 +30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mkholjuraev
approved these changes
Mar 1, 2023
adonispuente
force-pushed
the
ADVISOR-3016
branch
from
bf3d17d to
e886e9e
Compare
|
@mkholjuraev thanks for taking a look. I'll keep that in mind and be more cautious releasing to the other envs |
adonispuente
force-pushed
the
ADVISOR-3016
branch
from
e886e9e to
3ad1358
Compare
adonispuente
force-pushed
the
ADVISOR-3016
branch
from
3ad1358 to
d76f39a
Compare
gkarat
pushed a commit
that referenced
this pull request
Mar 6, 2023
## [1.7.1](v1.7.0...v1.7.1) (2023-03-06) ### Bug Fixes * **ADVISOR-3016:** Add perPage arg to getEntities ([#1777](#1777)) ([6b42a24](6b42a24))
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADVISOR-3016 describes a bug where the second half of items when loading in more than 50 (the default) items from inventory dont have the rhel version attached. This was because the inventory end point could never get all 100 as the arguments are filled in as undefined. This PR just allows it to get passed in.
Tested against Patch, Inventory, and Advisor.
How to Reproduce:
Expected results:
All hosts should show the respective OS versions.