feat(ESSNTL-3726): Add the /groups/%id page (group detail) #1771
Conversation
|
I think you're missing the group actions dropdown on the top right |
|
Other than missing dropdown - page looks good |
gkarat
force-pushed
the
essntl-3726-group-systems-page-init
branch
2 times, most recently
from
b15ce7c to
1b61129
Compare
src/Routes.js
Outdated
| <Route exact path={routes.groupDetail} component={groupsEnabled | ||
| ? InventoryGroupDetail | ||
| : () => ( | ||
| <EmptyState> |
There was a problem hiding this comment.
Is not this component exist on FEC with an already empty state? If this is the component for 404, it should be there, ready for consumption. Also, maybe we can extract this into some wrapper and avoid repetition?
There was a problem hiding this comment.
Didn't found the empty state-like components that could replace it. if you could point me out to any would be cool. meanwhile, I extracted this empty state to a separate component in the last commit 👍🏼
gkarat
force-pushed
the
essntl-3726-group-systems-page-init
branch
from
1b61129 to
4bc1f2e
Compare
Codecov ReportBase: 70.85% // Head: 69.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
- Coverage 70.85% 69.40% -1.45%
==========================================
Files 108 122 +14
Lines 2422 2579 +157
Branches 869 885 +16
==========================================
+ Hits 1716 1790 +74
- Misses 706 789 +83
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# [1.4.0](v1.3.1...v1.4.0) (2023-02-22) ### Features * **ESSNTL-3726:** Add the /groups/%id page (group detail) ([#1771](#1771)) ([ca24e55](ca24e55))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements https://issues.redhat.com/browse/ESSNTL-3726.
Mocks https://www.sketch.com/s/c19f555b-7887-4423-b55d-575c8dd1dfb7/a/52E5bap.
This adds a new route
/groups/%idwhereidis a group id. The page contains the breadcrumbs, header with the group name or id, and two tabs that contain placeholder (table and further components will be implemented soon). The feature is covered with unit and component tests (the component ones primarily check the right behavior under certain API responses).How to test
While running the PR locally together with mock server, navigate to
/groups/%idwith any custom id. The page should render expected content.Screenshots