Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert aws_token to string since sometimes it's unicode #3643

Merged
merged 1 commit into from
Dec 23, 2022
Merged

fix: Convert aws_token to string since sometimes it's unicode #3643

merged 1 commit into from
Dec 23, 2022

Conversation

huali027
Copy link
Contributor

@huali027 huali027 commented Dec 23, 2022

When I test the playbooks, I found the spec "aws_instance_id_doc" can not be collected on RHEL 7.5:

2022-12-23 08:42:34,794     INFO insights.core.dr Trying insights.specs.default.DefaultSpecs.aws_instance_id_doc
2022-12-23 08:42:34,794    DEBUG insights.core.plugins The provider can only be a single string or a tuple of strings, but got 'AQAAAPTeS4-aK9v5iEb27uBubd5HjzogWpB_-0K1_sgGoVverKIrkg=='.

After debugging it, I found the return type of aws_imdsv2_token is unicode.

Signed-off-by: Huanhuan Li [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

@huali027
Copy link
Contributor Author

@xiangce Please help to review, thanks.

Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huali027 - please 1. add the relevant description or add the issue; 2. add corresponding tests; 3. check the checkboxes if you finished them.

Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, no need to add tests for this change.

@xiangce xiangce changed the title fix: Transform it to string since sometimes it's unicode fix: Convert aws_token to string since sometimes it's unicode Dec 23, 2022
@xiangce xiangce merged commit 4f03a95 into RedHatInsights:master Dec 23, 2022
xiangce pushed a commit that referenced this pull request Dec 23, 2022
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants