Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of hiding, disable global filter #1133

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

karelhala
Copy link
Contributor

@karelhala karelhala commented Jan 21, 2021

Disable global filter

We want to show customers, that the global filter has been disabled instead of hide it completely. There is still an option to hide this filter, but that's only for places where app really don't want to show it.

JIRA https://issues.redhat.com/browse/RHCLOUD-11103

@karelhala karelhala requested a review from a team January 21, 2021 15:41
@codecov-io
Copy link

Codecov Report

Merging #1133 (42647ba) into master (d79ef63) will decrease coverage by 0.12%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
- Coverage   52.99%   52.87%   -0.13%     
==========================================
  Files          65       65              
  Lines        1317     1322       +5     
  Branches      260      260              
==========================================
+ Hits          698      699       +1     
- Misses        494      498       +4     
  Partials      125      125              
Impacted Files Coverage Δ
src/js/App/GlobalFilter/GlobalFilter.js 1.69% <0.00%> (-0.03%) ⬇️
src/js/App/GlobalFilter/constants.js 71.15% <ø> (ø)
src/js/chrome/entry.js 35.18% <0.00%> (-0.67%) ⬇️
src/js/redux/actions.js 71.42% <0.00%> (-2.65%) ⬇️
src/js/redux/globalFilterReducers.js 93.33% <0.00%> (-6.67%) ⬇️
src/js/redux/index.js 100.00% <ø> (ø)
src/js/App/RootApp.js 100.00% <100.00%> (ø)
src/js/redux/action-types.js 100.00% <100.00%> (ø)

@karelhala karelhala merged commit 4b70c7a into RedHatInsights:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants