Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] footer: h3 line height cascading. added 1.1rem (band aide) #790

Closed
Tracked by #476
heyMP opened this issue Mar 20, 2023 · 0 comments · Fixed by #811
Closed
Tracked by #476

[bug] footer: h3 line height cascading. added 1.1rem (band aide) #790

heyMP opened this issue Mar 20, 2023 · 0 comments · Fixed by #811
Assignees
@heyMP
Labels
bug Something isn't working
Milestone
RHDS Abra

Comments

@heyMP
Copy link
Member

heyMP commented Mar 20, 2023 •
edited
Loading

The h3[slot="links"] don't have an explicit line height set.

Screenshot 2023-03-20 at 8 45 56 PM

Solution

  • add a line-height in the shadowroot or lightdom for this selector rh-footer h3[slot="links"]
@heyMP heyMP added this to the RHDS Abra milestone Mar 20, 2023
@heyMP heyMP mentioned this issue Mar 20, 2023
Closed
13 tasks
@heyMP heyMP changed the title [bug] footer h3 line height cascading. added 1.1rem (band aide) [bug] footer: h3 line height cascading. added 1.1rem (band aide) Mar 20, 2023
@heyMP heyMP moved this from Backlog to In Progress in Red Hat Design System Mar 21, 2023
@heyMP heyMP self-assigned this Mar 21, 2023
@heyMP heyMP added the bug Something isn't working label Mar 21, 2023
@heyMP heyMP linked a pull request Mar 21, 2023 that will close this issue
fix(footer): add explicit typography tokens to headers #811
Merged
@heyMP heyMP moved this from In Progress to Review in Red Hat Design System Mar 21, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Red Hat Design System Mar 21, 2023
@github-actions github-actions bot mentioned this issue Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heyMP heyMP

Labels
bug Something isn't working
Projects
Red Hat Design System
Status: Done ☑️
Milestone
RHDS Abra
Development

Successfully merging a pull request may close this issue.

fix(footer): add explicit typography tokens to headers RedHat-UX/red-hat-design-system
1 participant
@heyMP