-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] <rh-footer> add font-size revert instead of px value for #312
Comments
@zeroedin is checking on the best corse of action on this. |
do we need a variable for this? Users that want to change the default should just rh-footer {
font-size: 25em; /* 🌶 */
} |
The fix I worked in for
This resets to initial but also allows a trap door if someone is adamant about setting that value. As for your question @bennypowers, do we need a variable? No probably not. Your solution is more valid just override directly in light dom and skip the CSS variable. |
Closed by #406 |
Description
rh-footer explicitly sets the font-size of the :host component to
18px
. This was a bandaid to account for sites that had different root font-sizes.Suggested solution
We should do this instead:
cc: @zeroedin @markcaron
The text was updated successfully, but these errors were encountered: